RSDK-2996 Release Candidate Workflows #2336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
removed
the
safe to test
viambot
added
the
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
the
safe to test
edaniels
approved these changes
May 9, 2023
|
|
||
| steps: | ||
| - name: Check out main branch code |
| - name: Upload Files (Testing) | ||
| if: github.event_name == 'workflow_dispatch' || github.event_name == 'push' | ||
| uses: google-github-actions/[email protected] | ||
| with: | ||
| headers: "cache-control: no-cache" | ||
| path: 'etc/packaging/appimages/deploy/' | ||
| destination: 'packages.viam.com/apps/viam-server/testing/appimage/${{ steps.build_test_app.outputs.date }}/${{ github.sha }}/' | ||
| destination: 'packages.viam.com/apps/viam-server/testing/appimage/${{ steps.build_date.outputs.date }}/${{ github.sha }}/' |
There was a problem hiding this comment.
For when we publish things, would you mind using https://github.blog/2022-05-09-supercharging-github-actions-with-job-summaries/ so it's easy to click Summary on the action?
There was a problem hiding this comment.
I didn't even know about that GITHUB_STEP_SUMMARY file. Cool stuff! I've added output to provide links to any built binaries. Two paths basically, one when PR artifacts are built (as that bails early) and another for any push-based triggers (tags or main updates.) Examples below:
Test run (PR triggered)
https://github.com/viamrobotics/rdk/actions/runs/4930753109
Test run (push triggered)
https://github.com/viamrobotics/rdk/actions/runs/4930749546
| @@ -106,10 +117,14 @@ jobs: | |||
|
|
|||
| - name: Test AppImage | |||
| run: | | |||
| channel="${{ github.ref_name }}" | |||
| if [ "$channel" = "main" ]; then | |||
| channel="latest" | |||
There was a problem hiding this comment.
short comment of why we do this here would be helpful
There was a problem hiding this comment.
Added # we call our main branch releases "latest"
| @@ -162,7 +162,7 @@ require ( | |||
| github.com/esimonov/ifshort v1.0.4 // indirect | |||
| github.com/ettle/strcase v0.1.1 // indirect | |||
| github.com/fatih/camelcase v1.0.0 // indirect | |||
| github.com/fatih/color v1.14.1 // indirect | |||
There was a problem hiding this comment.
can probably undo these two go files for this PR
There was a problem hiding this comment.
Actually it was required to update actionlint otherwise it failed to pass the new workflows due to this bug: rhysd/actionlint#263
| @@ -5,7 +5,7 @@ TOOL_BIN = bin/gotools/$(shell uname -s)-$(shell uname -m) | |||
| PATH_WITH_TOOLS="`pwd`/$(TOOL_BIN):`pwd`/node_modules/.bin:${PATH}" | |||
|
|
|||
| GIT_REVISION = $(shell git rev-parse HEAD | tr -d '\n') | |||
| TAG_VERSION?=$(shell etc/tag_version.sh) | |||
| TAG_VERSION?=$(shell git tag --points-at | sort -Vr | head -n1) | |||
| @@ -25,12 +23,16 @@ jobs: | |||
| appimage: | |||
| needs: test | |||
| uses: viamrobotics/rdk/.github/workflows/appimage.yml@main | |||
| with: | |||
There was a problem hiding this comment.
is there a way to set this once in the overall workflow?
There was a problem hiding this comment.
I tried with env variables, but they don't pass through. Only way I could find was to use inputs to each workflow like this (same as we have to do with secrets.)
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
|
edaniels
pushed a commit
that referenced
this pull request
May 11, 2023
bazile-clyde
pushed a commit
to bazile-clyde/rdk
that referenced
this pull request
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates workflows to support release candidate builds. Main changes are that each "type" of release has its own parent workflow now (main/stable/rc/pr) and sets an environment variable to match, to make it easier to do conditional logic in child workflows.
Includes is also some simplification of flow and security fixups for the license_finder flow (which was running directly on pull request!)
Manually tested against both stable and rc tags (from another branch) as well as PR's against this test branch, and pushes to this branch as "main." (SMURF tags/renames using during testing have already been reverted to simplify review.)