Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump vite in legacy #345

Merged
merged 3 commits into from
Aug 29, 2023
Merged

Bump vite in legacy #345

merged 3 commits into from
Aug 29, 2023

Conversation

DTCurrie
Copy link
Member

Resolves #342

@DTCurrie DTCurrie requested a review from mcous August 25, 2023 20:23
@DTCurrie DTCurrie self-assigned this Aug 25, 2023
mcous
mcous approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@mcous mcous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does vite (and/or vitest) need to be bumped in any other projects, too?

@DTCurrie
Copy link
Member Author

Does vite (and/or vitest) need to be bumped in any other projects, too?

This puts everything inline to use the same version of vite which was ahead of the dependabot alert. I didn't want to push anything else with this.

@DTCurrie DTCurrie merged commit 327b7a3 into viamrobotics:main Aug 29, 2023
@DTCurrie DTCurrie deleted the bump-vite branch August 29, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcous mcous mcous approved these changes

Assignees

@DTCurrie DTCurrie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DTCurrie @mcous