Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Aurora Corne by splitkb #589

Closed
wants to merge 1 commit into from

Conversation

artursmirnov
Copy link

Mostly just added a keymap layout for the keyboard and enabled Vial support following the guide. Tested the integration with my keyboard.

Copy link
Contributor

@lesshonor lesshonor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the integration with my keyboard.

...I'm going to be charitable and assume that you're using an ARM Micro, because otherwise this keymap is massively oversize.

At present keymaps submitted to this repository still need to build for their original target platforms (i.e. AVR). The following resources may help:

@@ -0,0 +1,49 @@
{
"keyboard": "splitkb/aurora/corne/rev1",
"keymap": "default",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"keymap": "default",
"keymap": "vial",

"features": {
"oled": true,
"rgb_matrix": true,
"rgblight": false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"rgblight": false
"rgblight": false,
"via": true,
"vial": true

Comment on lines +1 to +17
# Copyright 2022 splitkb.com <[email protected]>
#
# This program is free software: you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation, either version 2 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.

VIA_ENABLE = yes
VIAL_ENABLE = yes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say that you could delete this file entirely but you probably want to start selectively disabling features here so the firmware actually builds. Here's an example of that syntax.

Suggested change
# Copyright 2022 splitkb.com <[email protected]>
#
# This program is free software: you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation, either version 2 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
VIA_ENABLE = yes
VIAL_ENABLE = yes
ifeq ($(strip $(MCU)), atmega32u4)
QMK_SETTINGS = no
endif

...Also you can leave the huge license blob off rules.mk files. QMK's collaborators have actually been trying to get splitkb's contractors to stop cut-pasting it in.

@thomasbaart
Copy link
Contributor

thomasbaart commented Nov 8, 2023

Hi! We're starting to add Vial support for all our keyboards soon, so we'll either raise changes to this PR or raise a new PR once we're ready. Thanks for the pointers @lesshonor, I'll make sure we take them into account.

Thank you Artur for the work! It's cool to see keymaps being added :)

The license headers already existed in other firmware that did get approved, so we tried to match as closely to existing firmware as possible. The process isn't always uniform for every PR due to the nature of the project, so I reckon things need a little more ironing sometimes ;)

Now I'm here anyway: Would it be worthwhile to raise all keyboards as a single PR, so we can apply any desired changes in one swoop and have it all nice and equal?

@lesshonor
Copy link
Contributor

Would it be worthwhile to raise all keyboards as a single PR, so we can apply any desired changes in one swoop and have it all nice and equal?

You can add and/or revise keymaps for all your boards in one fell swoop if you want. If everything passes CI checks it will almost certainly be merged (at xyz's convenience; I have no control over the process).

@xyzz
Copy link
Contributor

xyzz commented Feb 10, 2024

Closing because there's been no update for over a month.

@xyzz xyzz closed this Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants