-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add clang-repl tests to make sure we do not break repls. #872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgvassilev
force-pushed
the
add-clang-repl-test
branch
from
April 26, 2024 13:41
92fc173
to
77ed5b4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #872 +/- ##
=======================================
Coverage 94.81% 94.81%
=======================================
Files 51 51
Lines 7618 7620 +2
=======================================
+ Hits 7223 7225 +2
Misses 395 395
|
clang-tidy review says "All clean, LGTM! 👍" |
vgvassilev
force-pushed
the
add-clang-repl-test
branch
from
April 26, 2024 17:55
77ed5b4
to
9ff24d9
Compare
clang-tidy review says "All clean, LGTM! 👍" |
vgvassilev
force-pushed
the
add-clang-repl-test
branch
from
April 26, 2024 18:08
9ff24d9
to
eaead8b
Compare
clang-tidy review says "All clean, LGTM! 👍" |
vgvassilev
force-pushed
the
add-clang-repl-test
branch
from
April 26, 2024 18:35
eaead8b
to
2f0ca61
Compare
clang-tidy review says "All clean, LGTM! 👍" |
vgvassilev
force-pushed
the
add-clang-repl-test
branch
from
April 26, 2024 19:10
2f0ca61
to
989395d
Compare
clang-tidy review says "All clean, LGTM! 👍" |
vgvassilev
force-pushed
the
add-clang-repl-test
branch
from
April 27, 2024 07:24
989395d
to
509e151
Compare
clang-tidy review says "All clean, LGTM! 👍" |
parth-07
approved these changes
Apr 28, 2024
vaithak
approved these changes
Apr 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #854, fixes #867.