Improve test for derivatives of Struct Method Calls #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#49 is already fixed; this just ensures that we have proper testing for the examples mentioned in the issue. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #719 +/- ##
==========================================
+ Coverage 94.54% 94.60% +0.05%
==========================================
Files 49 49
Lines 7189 7189
==========================================
+ Hits 6797 6801 +4
+ Misses 392 388 -4
|
vgvassilev
reviewed
Jan 19, 2024
| // CHECK-NEXT: int _d_x = 0; | ||
| // CHECK-NEXT: int _d_y = 1; | ||
| // CHECK-NEXT: int _d_x = 0; | ||
| // CHECK-NEXT: int _d_y = 1; |
There was a problem hiding this comment.
Do we need these white space changes?
There was a problem hiding this comment.
I would say yes, because this makes the spacing uniform.with other lines of the same generated function and also matches the expected spacing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #49