Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move more cases computing the derivative name in ComputeDerivativeName. #1195

Merged
merged 1 commit into from
Dec 28, 2024

Conversation

vgvassilev
Copy link
Owner

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

lib/Differentiator/DiffPlanner.cpp Show resolved Hide resolved
lib/Differentiator/DiffPlanner.cpp Outdated Show resolved Hide resolved
lib/Differentiator/DiffPlanner.cpp Outdated Show resolved Hide resolved
lib/Differentiator/DiffPlanner.cpp Outdated Show resolved Hide resolved
lib/Differentiator/ReverseModeVisitor.cpp Show resolved Hide resolved
Copy link

codecov bot commented Dec 28, 2024

Codecov Report

Attention: Patch coverage is 97.67442% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.84%. Comparing base (c893c31) to head (49622f1).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
lib/Differentiator/DiffPlanner.cpp 97.05% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1195      +/-   ##
==========================================
- Coverage   94.86%   94.84%   -0.03%     
==========================================
  Files          51       51              
  Lines        8977     8921      -56     
==========================================
- Hits         8516     8461      -55     
+ Misses        461      460       -1     
Files with missing lines Coverage Δ
include/clad/Differentiator/ParseDiffArgsTypes.h 100.00% <100.00%> (ø)
lib/Differentiator/ReverseModeVisitor.cpp 95.55% <100.00%> (-0.04%) ⬇️
lib/Differentiator/VectorForwardModeVisitor.cpp 99.69% <100.00%> (-0.01%) ⬇️
lib/Differentiator/DiffPlanner.cpp 98.21% <97.05%> (-0.15%) ⬇️

... and 3 files with indirect coverage changes

Files with missing lines Coverage Δ
include/clad/Differentiator/ParseDiffArgsTypes.h 100.00% <100.00%> (ø)
lib/Differentiator/ReverseModeVisitor.cpp 95.55% <100.00%> (-0.04%) ⬇️
lib/Differentiator/VectorForwardModeVisitor.cpp 99.69% <100.00%> (-0.01%) ⬇️
lib/Differentiator/DiffPlanner.cpp 98.21% <97.05%> (-0.15%) ⬇️

... and 3 files with indirect coverage changes

@vgvassilev vgvassilev merged commit a2e1c50 into master Dec 28, 2024
92 checks passed
@vgvassilev vgvassilev deleted the derive-9 branch December 28, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant