Improve DiffRequest and DynamicGraph printing. #1183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| /// Print the nodes and edges in the graph. | ||
| void print() { | ||
| void print(llvm::raw_ostream& Out) const { |
There was a problem hiding this comment.
warning: use of undeclared identifier 'llvm' [clang-diagnostic-error]
void print(llvm::raw_ostream& Out) const {
^
vgvassilev
force-pushed
the
improve-graph-print
branch
from
5293c39 to
8cf35b3
Compare
| #include "clang/AST/RecursiveASTVisitor.h" | ||
|
|
||
| #include "llvm/ADT/SmallSet.h" | ||
| #include <llvm/Support/raw_ostream.h> |
There was a problem hiding this comment.
warning: included header SmallSet.h is not used directly [misc-include-cleaner]
Suggested change
| #include <llvm/Support/raw_ostream.h> | |
| #include <llvm/Support/raw_ostream.h> |
vgvassilev
force-pushed
the
improve-graph-print
branch
3 times, most recently
from
bb87743 to
b1934fe
Compare
vgvassilev
force-pushed
the
improve-graph-print
branch
2 times, most recently
from
f9b28cf to
c5f787b
Compare
| #include "FunctionTraits.h" | ||
| #include "Matrix.h" | ||
| #include "NumericalDiff.h" | ||
| #include "Tape.h" | ||
|
|
||
| #include <array> | ||
| #include <assert.h> |
There was a problem hiding this comment.
warning: included header array is not used directly [misc-include-cleaner]
Suggested change
| #include <assert.h> | |
| #include <assert.h> |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1183 +/- ##
==========================================
+ Coverage 94.56% 94.85% +0.28%
==========================================
Files 51 51
Lines 8960 8972 +12
==========================================
+ Hits 8473 8510 +37
+ Misses 487 462 -25
... and 1 file with indirect coverage changes
|
vgvassilev
force-pushed
the
improve-graph-print
branch
from
c5f787b to
d21d69a
Compare
vgvassilev
force-pushed
the
improve-graph-print
branch
from
d21d69a to
0fd17d9
Compare
vgvassilev
force-pushed
the
improve-graph-print
branch
from
0fd17d9 to
1a55b91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.