Respect shadow declarations when writing propagators. #1171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
vgvassilev
force-pushed
the
fix-shadows
branch
from
27958c3 to
9dcde57
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
vgvassilev
force-pushed
the
fix-shadows
branch
2 times, most recently
from
58d68d6 to
a754eda
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
vgvassilev
force-pushed
the
fix-shadows
branch
from
a754eda to
7b83fe4
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1171 +/- ##
==========================================
+ Coverage 94.56% 94.57% +0.01%
==========================================
Files 51 51
Lines 8942 8959 +17
==========================================
+ Hits 8456 8473 +17
Misses 486 486
|
|
clang-tidy review says "All clean, LGTM! 👍" |
In cases where the public declaration is introduced with using declaration pointing to an internal namespace with the implementation details, we should put the propagator function in the namespace of the public function and not the implementation. That would allow users to position their pullbacks in the same namespace structure as the used functions.
vgvassilev
force-pushed
the
fix-shadows
branch
from
4366764 to
546c8d6
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
PetroZarytskyi
approved these changes
Dec 16, 2024
|
LGTM! |
This was referenced Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where the public declaration is introduced with using declaration pointing to an internal namespace with the implementation details, we should put the propagator function in the namespace of the public function and not the implementation. That would allow users to position their pullbacks in the same namespace structure as the used functions.
Depends on #1172