Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clone base decl when having an anonymous struct or union #1152

Merged
merged 2 commits into from
Nov 23, 2024

Conversation

kchristin22
Copy link
Collaborator

Fixes #1151

When having an anonymous member expression, the declaration of its base is cloned instead of this empty decl.

@kchristin22 kchristin22 self-assigned this Nov 22, 2024
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.56%. Comparing base (b5e0d12) to head (d1f9559).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1152   +/-   ##
=======================================
  Coverage   94.56%   94.56%           
=======================================
  Files          51       51           
  Lines        8941     8944    +3     
=======================================
+ Hits         8455     8458    +3     
  Misses        486      486           
Files with missing lines Coverage Δ
lib/Differentiator/ReverseModeVisitor.cpp 95.60% <100.00%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
lib/Differentiator/ReverseModeVisitor.cpp 95.60% <100.00%> (+<0.01%) ⬆️
---- 🚨 Try these New Features:

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@vgvassilev vgvassilev merged commit 693b1bd into vgvassilev:master Nov 23, 2024
90 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Segfault on anonymous struct
2 participants