Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to using xeus-cpp instead of xeus-cling #1017

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

vgvassilev
Copy link
Owner

Fixes #985.

Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.10%. Comparing base (e9c47b7) to head (541afba).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1017      +/-   ##
==========================================
+ Coverage   94.00%   94.10%   +0.09%     
==========================================
  Files          55       55              
  Lines        8139     8225      +86     
==========================================
+ Hits         7651     7740      +89     
+ Misses        488      485       -3     

see 4 files with indirect coverage changes

see 4 files with indirect coverage changes

@davidlange6
Copy link
Collaborator

fwiw, I tried this and see that it doesn't preserve current behavior of printing results - eg, the first intro notebook example results the image below. (also a compilation error means restarting the kernel - though I do not believe that to be a regression.

image

@vgvassilev
Copy link
Owner Author

Yes, if you replace it with printf it works but there are still a few issues. I've asked @tharun571 to take a look.

@anutosh491
Copy link

anutosh491 commented Sep 30, 2024

I was looking into some functionality for xeus-clad (maybe using xeus-cpp). Is this good to go ?

@tharun571
Copy link

I was looking into some functionality for xeus-clad (maybe using xeus-cpp). Is this good to go ?

I don't think so. There are some functional discrepancies present. Hessian and Jacobian functions do not work as intended with xeus-cpp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move the binder service from xeus-cling to xeus-cpp
4 participants