Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple test assertion failures on master #428

Open
grimmmyshini opened this issue Apr 20, 2022 · 3 comments
Open

Multiple test assertion failures on master #428

grimmmyshini opened this issue Apr 20, 2022 · 3 comments
Assignees
Milestone

Comments

@grimmmyshini
Copy link
Contributor

There are multiple assertion failures on debug master. Of all, some include:

void clang::CodeGen::CodeGenFunction::EmitCallArgs(clang::CodeGen::CallArgList&, const T*, llvm::iterator_range<clang::Stmt::CastIterator<clang::Expr, const clang::Expr* const, const clang::Stmt* const> >, clang::CodeGen::CodeGenFunction::AbstractCallee, unsigned int, clang::CodeGen::CodeGenFunction::EvaluationOrder) [with T = clang::FunctionProtoType]: 
Assertion `(isGenericMethod || ((*I)->isVariablyModifiedType() || (*I).getNonReferenceType()->isObjCRetainableType() || getContext() .getCanonicalType((*I).getNonReferenceType()) .getTypePtr() == getContext() .getCanonicalType((*Arg)->getType()) .getTypePtr())) && "type mismatch in call argument!"' failed.

and

void clang::ClassTemplateSpecializationDecl::setPointOfInstantiation(clang::SourceLocation): 
Assertion `Loc.isValid() && "point of instantiation must be valid!"' failed.
@vaithak
Copy link
Collaborator

vaithak commented Jan 17, 2024

We can close this one too, now that we have a CI test for debug mode and it is passing.
cc: @vgvassilev

@vgvassilev
Copy link
Owner

@vaithak, not really because they are marked as XFAIL: asserts we still have work to do here.

@vgvassilev
Copy link
Owner

This depends on the approach solving #248 where we delay all of the differentiation until the end of the translation unit.

@vgvassilev vgvassilev self-assigned this Feb 12, 2024
@vgvassilev vgvassilev added this to the v1.5 milestone Feb 12, 2024
@vgvassilev vgvassilev modified the milestones: v1.5, v1.6 Apr 24, 2024
@vgvassilev vgvassilev assigned MihailMihov and unassigned vgvassilev May 22, 2024
@vgvassilev vgvassilev modified the milestones: v1.6, v1.7 Jul 6, 2024
@vgvassilev vgvassilev modified the milestones: v1.7, v1.8 Aug 4, 2024
vgvassilev pushed a commit that referenced this issue Nov 13, 2024
A valid location is required by the debug clang.

Partially addresses #428.
@vgvassilev vgvassilev assigned vgvassilev and unassigned MihailMihov Dec 10, 2024
@vgvassilev vgvassilev modified the milestones: v1.8, v1.9 Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants