Fix Clang-Tidy warnings.

vgvassilev · Nov 21, 2023 · fee07c4 · vgvassilev · Nov 21, 2023 · PetroZarytskyi
1 parent 810b485
commit fee07c4
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/lib/Differentiator/CladUtils.cpp b/lib/Differentiator/CladUtils.cpp
@@ -602,7 +602,7 @@ namespace clad {
       if (isa<clang::AutoType>(T))
         return true;
 
-      if (const auto pointerType = dyn_cast<clang::PointerType>(T)) {
+      if (const auto *const pointerType = dyn_cast<clang::PointerType>(T)) {
         return IsAutoOrAutoPtrType(
             pointerType->getPointeeType());
       }

diff --git a/lib/Differentiator/ReverseModeVisitor.cpp b/lib/Differentiator/ReverseModeVisitor.cpp
@@ -1124,7 +1124,7 @@ Expr* getArraySizeExpr(const ArrayType* AT, ASTContext& context,
     /// This is a temporary measure to avoid the bug that arises from overwriting
     /// local variables on different loop passes.
     Expr* forwardCond = cond.getExpr();
-    if (condVarRes.getExpr() && isa<Expr>(condVarRes.getExpr())) {
+    if (condVarRes.getExpr() != nullptr && isa<Expr>(condVarRes.getExpr())) {
       forwardCond = BuildOp(BO_Comma, cond.getExpr(), cast<Expr>(condVarRes.getExpr()));
     }
 

diff --git a/lib/Differentiator/TBRAnalyzer.cpp b/lib/Differentiator/TBRAnalyzer.cpp
@@ -202,9 +202,9 @@ TBRAnalyzer::VarData::VarData(const QualType QT) {
   } else if (QT->isBuiltinType()) {
     type = VarData::FUND_TYPE;
     val.m_FundData = false;
-  } else if (QT->isRecordType()) {
+  } else if (const auto* recordType = QT->getAs<RecordType>()) {
     type = VarData::OBJ_TYPE;
-    const auto* recordDecl = QT->getAs<RecordType>()->getDecl();
+    const auto* recordDecl = recordType->getDecl();
     auto& newArrMap = val.m_ArrData;
     newArrMap = std::unique_ptr<ArrMap>(new ArrMap());
     for (const auto* field : recordDecl->fields()) {