Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
To be copied to the draft changelog by merger:
Description
Update the semantics of WFA over GBWT. The endpoints of the alignment must still be on the haplotype the sequence is aligned to, but they are not included in the alignment itself. In other words, the alignment will be strictly between the endpoints. If the endpoints are identical, alignment is possible only if there is a cycle.
Also added proper error handling to the alignment object:
Now we can tell the difference between an empty alignment (an empty sequence aligns to a path between two adjacent endpoints) and a failure.
Also added new tests for various special cases.