Fix Out of Order Veritcal Transitions #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamnovak
approved these changes
Feb 26, 2024
Comment on lines
+981
to
+995
| while (AIndex < pathA.length && BIndex < pathB.length) { | ||
| let trackAOrder = pathA[AIndex].order; | ||
| let trackBOrder = pathB[BIndex].order; | ||
| if (trackAOrder === trackBOrder && pathA[AIndex].node && pathB[BIndex].node) { | ||
| return pathB[BIndex].y - pathA[AIndex].y; | ||
| } else if (trackAOrder < trackBOrder) { | ||
| AIndex += 1; | ||
| } else if (trackAOrder > trackBOrder) { | ||
| BIndex += 1; | ||
| } else { | ||
| // Orders are equal but are traversing out of nodes | ||
| AIndex += 1; | ||
| BIndex += 1; | ||
| } | ||
| } |
There was a problem hiding this comment.
This looks like it might get slow for a lot of long tracks needing to be compared, but I can't think of a better way to do it that's simple.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An offset designated for each node is used when generating vertical components of tracks. This leads to vertical transitions being determined by the order of the input tracks.
sequenceTubeMap/src/util/tubemap.js
Lines 2942 to 2953 in f4ab3c2
sequenceTubeMap/src/util/tubemap.js
Line 3010 in f4ab3c2
Tracks are now sorted based on how their horizontal components are ordered before generating vertical rectangles, allowing the offsets to work in a more predictable manner.
Closes #395