Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cygwin, support Windows-style parameter paths #510

Merged
merged 2 commits into from
Apr 23, 2018
Merged

Cygwin, support Windows-style parameter paths #510

merged 2 commits into from
Apr 23, 2018

Conversation

benrubson
Copy link
Contributor

Hi,

This PR enables the use of Windows-style paths as parameters.
Now, user can use for example :
encfs C:\cipher X:

Thank you 👍

Ben

Enable the use of Windows-style paths as parameters.
Now, user can use for example : encfs C:\cipher X:
A new internal option, unmountPoint, then keeps the mount point as provided by the user.
@benrubson
Copy link
Contributor Author

So as you can see here I had to create a new internal configuration item, unmountPoint, to retain mount point as originally provided by the user.
In Cygwin, pkill is used to unmount, and in order to identify the correct encfs process to stop (one could mount several FS at the same time), pkill looks at the whole encfs command line for the given mount point.
Unfortunately, the existing internal configuration item mountPoint is updated (from Win to Linux if needed, and with a trailing slash), so can't be used to unmount, as it would have chances not to match existing processes.

I did not found an easier/shorter way to solve this issue.

@benrubson benrubson merged commit 6c1fde2 into vgough:master Apr 23, 2018
@benrubson benrubson deleted the cygpath branch April 23, 2018 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants