Correct ato* clang warnings #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfjakob
reviewed
Oct 29, 2017
| @@ -644,7 +644,7 @@ static Cipher::CipherAlgorithm selectCipherAlgorithm() { | |||
| cout << "\n" << _("Enter the number corresponding to your choice: "); | |||
| char answer[10]; | |||
| char *res = fgets(answer, sizeof(answer), stdin); | |||
| int cipherNum = (res == nullptr ? 0 : atoi(answer)); | |||
| int cipherNum = (res == nullptr ? 0 : (int)strtol(answer, nullptr, 10)); | |||
There was a problem hiding this comment.
Hmm, where is the improvement here? Still no check if we got a valid number.
There was a problem hiding this comment.
Thx for your review !
Goal is at least to remove warnings.
There is a check just after strtol(), so it's OK.
In XmlReader.cpp, I've added checks which were not done before.
Thx !
rfjakob
approved these changes
Nov 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR helps with #427, it solves clang warnings regarding ato* functions.
Thank you 👍
Ben