Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all Yadio currencies to app and offer currencies support #1160

Merged

Conversation

SamTremko
Copy link
Contributor

No description provided.

@SamTremko SamTremko force-pushed the feat-1155_add_in_app_support_for_currencies_from_Yadio branch from a24d72b to eb9016f Compare June 19, 2024 14:43
@SamTremko SamTremko marked this pull request as ready for review June 19, 2024 14:43
@SamTremko SamTremko requested a review from kaladivo June 19, 2024 14:43
@SamTremko SamTremko force-pushed the feat-1155_add_in_app_support_for_currencies_from_Yadio branch from eb9016f to fb398f7 Compare June 19, 2024 14:44
Copy link
Collaborator

@kaladivo kaladivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small stuff, If you feel like it, look into it, but can be also merged as is :)

onItemPress: () => void
updateCurrencyLimitsAtom: WritableAtom<
null,
[
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be moved to one type that is used by CurrenciesList and CurrencySelectListItem


return (
<TouchableOpacity
onPress={() => {
updateCurrencyLimits({currency: currency.code})
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, this is good catch. Totally forgot about that. Sorry for complications

@SamTremko SamTremko force-pushed the feat-1155_add_in_app_support_for_currencies_from_Yadio branch from fb398f7 to c90bbf0 Compare June 19, 2024 16:41
@SamTremko SamTremko enabled auto-merge (rebase) June 19, 2024 16:41
@SamTremko SamTremko merged commit 4e547ba into main Jun 19, 2024
3 checks passed
@SamTremko SamTremko deleted the feat-1155_add_in_app_support_for_currencies_from_Yadio branch June 19, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants