This repository has been archived by the owner on Jun 19, 2024. It is now read-only.
feat: add object_size method to distance sensor
#73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gavin-Niederman
approved these changes
Jan 23, 2024
|
I'm debating on whether or not this should be returned as a percentage or 0.0-1.0 since it's unitless and the 0-400 scale PROS uses is rather arbitrary (and comes from the SDK). Pretty sure its 0-400 because VEXCode parses it into an enum with 4 arbitrary "sizes". |
This reverts commit 250c228.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes this PR makes. Why should it be merged?
Adds a high-level binding to
distance_get_object_size. This returns a unitless value that guesses the size of the scanned object.Additional Context
Have not tested on V5 hardware. Don't have access to a distance sensor either. The binding is pretty straightforward, though.