Pass basic auth settings in baseURL to xmlrpc lib #17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also took the liberty to replace the legacy
url.parse
with the nodejsURL
class.This may or may not be a breaking change, since
url.parse
only throws aTypeError
if the given URL is not a string. TheURL
class throws the error, if the input is not a valid URL.See https://nodejs.org/api/url.html#url_new_url_input_base
and https://nodejs.org/api/url.html#url_url_parse_urlstring_parsequerystring_slashesdenotehost