Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support cpplint style check automatically before commit #81

Merged
merged 2 commits into from
Jan 14, 2019
Merged

Support cpplint style check automatically before commit #81

merged 2 commits into from
Jan 14, 2019

Conversation

darionyaphet
Copy link
Contributor

Support cpplint style check automatically before commit

  • Before commit to repo, cpplint will check the *.h and *.cpp automatically which add to the repo.
  • Using cpplint/bin/style_checker.sh could check the specify directory.
    It looks like : cpplint/bin/style_checker.sh <directory>

@nebula-community-bot
Copy link
Member

Build succeeded.

@dangleptr
Copy link
Contributor

dangleptr commented Jan 11, 2019 •
edited
Loading

Perfect!! We really need it to constrain our code style. Let me try it.

@dangleptr dangleptr mentioned this pull request Jan 11, 2019
Closed
@nebula-community-bot
Copy link
Member

Build succeeded.

@dangleptr
Copy link
Contributor

dangleptr commented Jan 11, 2019 •
edited
Loading

Try it on my local env. I found the files generated by third library been checked. For example:

src/CMakeFiles/3.11.4/CompilerIdCXX/CMakeCXXCompilerId.cpp
src/parser/GraphParser.cpp
src/parser/GraphScanner.cpp
src/interface/gen-cpp2/graph_types.h
...

Could we shadow them ?

There are also some other problems about check rules, for example:

  1. Line length should be 100.
  2. The warning "public: should be indented +1 space inside class xxx " should be closed.

@nebula-community-bot
Copy link
Member

Build succeeded.

@nebula-community-bot
Copy link
Member

Build succeeded.

1 similar comment
@nebula-community-bot
Copy link
Member

Build succeeded.

dangleptr
dangleptr previously approved these changes Jan 14, 2019
View reviewed changes
Copy link
Contributor

@dangleptr dangleptr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test it locally, looks good to me now. Let's fix all code style issues according to it.

@dangleptr dangleptr mentioned this pull request Jan 14, 2019
Closed
@nebula-community-bot
Copy link
Member

Build succeeded.

1 similar comment
@nebula-community-bot
Copy link
Member

Build succeeded.

@dangleptr dangleptr merged commit 1d1172d into vesoft-inc:master Jan 14, 2019
@dangleptr dangleptr mentioned this pull request Jan 14, 2019
Merged
@dutor dutor deleted the issues-73 branch January 17, 2019 08:28
@MatrixOwl MatrixOwl mentioned this pull request Dec 15, 2019
Closed
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Feb 16, 2020
@darionyaphet @dangleptr
support cpplint code style checker (vesoft-inc#81)
d0a5855
tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
@darionyaphet @dangleptr
support cpplint code style checker (vesoft-inc#81)
c685047
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Mar 21, 2022
@nebula-bots @liuyu85cn
if space dropped before task finish report, the job status should be …
218cf89 
…marked finished (vesoft-inc#81)

Co-authored-by: liuyu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dangleptr dangleptr dangleptr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@darionyaphet @nebula-community-bot @dangleptr