Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement snapshot logic #795

Merged
merged 9 commits into from
Sep 3, 2019
Merged

Implement snapshot logic #795

merged 9 commits into from
Sep 3, 2019

Conversation

dangleptr
Copy link
Contributor

@dangleptr dangleptr commented Aug 16, 2019

subtask of #182

@dangleptr dangleptr added ready-for-testing PR: ready for the CI test and removed in progress labels Aug 21, 2019
@dangleptr
Copy link
Contributor Author

Jenkins go

@dangleptr dangleptr requested a review from darionyaphet August 21, 2019 03:26
@nebula-community-bot
Copy link
Member

Unit testing failed.

2 similar comments
@nebula-community-bot
Copy link
Member

Unit testing failed.

@nebula-community-bot
Copy link
Member

Unit testing failed.

@nebula-community-bot
Copy link
Member

Unit testing failed.

1 similar comment
@nebula-community-bot
Copy link
Member

Unit testing failed.

@nebula-community-bot
Copy link
Member

Unit testing failed.

@dangleptr dangleptr added in progress ready-for-testing PR: ready for the CI test and removed ready-for-testing PR: ready for the CI test in progress labels Aug 21, 2019
@dangleptr
Copy link
Contributor Author

Jenkins go

@nebula-community-bot
Copy link
Member

Unit testing passed.

1 similar comment
@nebula-community-bot
Copy link
Member

Unit testing passed.

src/kvstore/Part.cpp Outdated Show resolved Hide resolved
@nebula-community-bot
Copy link
Member

Unit testing failed.

@dangleptr
Copy link
Contributor Author

Jenkins go

@nebula-community-bot
Copy link
Member

Unit testing passed.

3 similar comments
@nebula-community-bot
Copy link
Member

Unit testing passed.

@nebula-community-bot
Copy link
Member

Unit testing passed.

@nebula-community-bot
Copy link
Member

Unit testing passed.

@dangleptr dangleptr mentioned this pull request Sep 2, 2019
src/kvstore/raftex/RaftPart.cpp Show resolved Hide resolved
src/kvstore/raftex/RaftPart.cpp Show resolved Hide resolved
src/kvstore/Part.cpp Show resolved Hide resolved
@darionyaphet
Copy link
Contributor

LGTM & thanks for you explain.

@nebula-community-bot
Copy link
Member

Unit testing passed.

@dangleptr dangleptr merged commit 0121cb2 into vesoft-inc:master Sep 3, 2019
@dangleptr dangleptr deleted the snapshot branch September 3, 2019 09:44
tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
* Implement snapshot logic

* Address critical27's and wadeliuyi's comments

* Address darion's and wadeliuyi's comments, rebase on master and fix failed UTs

* Address wadeliuyi's comments

* Fix failed UT leader_transfer_test

* Open disabled UTs in vesoft-inc#859

* Add some checks when receiving snapshot and adjust some log levels
liwenhui-soul pushed a commit to liwenhui-soul/nebula that referenced this pull request May 10, 2022
* fix updatePart

* fix format check

Co-authored-by: Sophie <[email protected]>

Co-authored-by: Doodle <[email protected]>
Co-authored-by: Sophie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants