Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace DCHECK_NOTNULL with DCHECK in TraverseExecutor. #758

Merged
merged 2 commits into from
Aug 13, 2019

Conversation

CPWstatic
Copy link
Contributor

DCHECK_NOTNULL not work well when compile release version.

Copy link
Contributor

@laura-ding laura-ding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done

@CPWstatic CPWstatic added the ready-for-testing PR: ready for the CI test label Aug 13, 2019
@CPWstatic
Copy link
Contributor Author

Jenkins go!

@nebula-community-bot
Copy link
Member

Unit testing passed.

Copy link
Contributor

@dutor dutor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nebula-community-bot
Copy link
Member

Unit testing passed.

@dutor dutor merged commit 01d194e into vesoft-inc:master Aug 13, 2019
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Feb 16, 2020
tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
liwenhui-soul pushed a commit to liwenhui-soul/nebula that referenced this pull request May 10, 2022
* use #cache entries to set cache

* fix bug

* update comments in config

Co-authored-by: Sophie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants