Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

option to enable build-in log rotation enabled leveraging glog #5688 #5958

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

E2ern1ty
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

#5688

Description:

add option log_clean_days to enable build-in log rotation enabled leveraging glog

How do you solve it?

use google::EnableLogCleaner func

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@E2ern1ty E2ern1ty requested a review from a team as a code owner October 12, 2024 03:31
@zhanghuidinah zhanghuidinah requested a review from wey-gu October 16, 2024 01:30
@E2ern1ty
Copy link
Contributor Author

I turned off the ntp service in the test cluster and set the time through the date command. The log can be automatically cleared when the new log is refreshed.

@yixinglu yixinglu added the ready-for-testing PR: ready for the CI test label Oct 18, 2024
@yixinglu yixinglu enabled auto-merge (squash) October 18, 2024 06:45
@zhanghuidinah zhanghuidinah added the hacktoberfest hacktoberfest events label Oct 18, 2024
@wey-gu
Copy link
Contributor

wey-gu commented Oct 18, 2024

Thanks for the great work :-D

@yixinglu yixinglu merged commit b011aa2 into vesoft-inc:master Oct 18, 2024
4 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest hacktoberfest events ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants