Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix. date validator will reject 00 in day part. #5907

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

UndefinedSy
Copy link

the validateDate impl only checks the overflow of day part, which allows input like DATE("2024-07-00"). this will lead to error in reading process.

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

5906

Description:

the `validateDate` impl only checks the overflow of day part,
which allows input like DATE("2024-07-00"). this will lead to
error in the reading process.

How do you solve it?

add check in `validateDate`

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@CLAassistant
Copy link

CLAassistant commented Jul 5, 2024

CLA assistant check
All committers have signed the CLA.

the `validateDate` impl only checks the overflow of day part,
which allows input like DATE("2024-07-00"). this will lead to
error in the reading process.
@UndefinedSy UndefinedSy force-pushed the BR_FIX_INVALID_DATE branch from a570d34 to b828172 Compare July 5, 2024 05:48
@zhanghuidinah zhanghuidinah requested a review from yixinglu July 8, 2024 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants