Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix filter bug #5720

Merged
merged 2 commits into from
Sep 19, 2023
Merged

fix filter bug #5720

merged 2 commits into from
Sep 19, 2023

Conversation

nevermore3
Copy link
Contributor

@nevermore3 nevermore3 commented Sep 19, 2023

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

close https://github.com/vesoft-inc/nebula-ent/issues/3179

Description:

When the filter operator is running concurrently, if the condition is abnormal in the scatter function (WHERE v.player.name STARTS WITH 1), an error message will be returned. This exception error message needs to be captured in the gather function.

    if (val.isBadNull() || (!val.empty() && !val.isImplicitBool() && !val.isNull())) {
      return Status::Error("Failed to evaluate condition: %s. %s%s",
                           condition->toString().c_str(),
                           "For boolean conditions, please write in their full forms like",
                           " <condition> == <true/false> or <condition> IS [NOT] NULL.");
    }

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

yixinglu
yixinglu previously approved these changes Sep 19, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 20.00% and project coverage change: +1.13% 🎉

Comparison is base (3a74633) 77.10% compared to head (3a84045) 78.24%.
Report is 1 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5720      +/-   ##
==========================================
+ Coverage   77.10%   78.24%   +1.13%     
==========================================
  Files        1133     1133              
  Lines       85884    85924      +40     
==========================================
+ Hits        66220    67230    +1010     
+ Misses      19664    18694     -970     
Files Changed Coverage Δ
src/graph/executor/query/FilterExecutor.cpp 45.74% <0.00%> (-0.50%) ⬇️
src/kvstore/raftex/Host.cpp 71.81% <0.00%> (-5.58%) ⬇️
src/kvstore/raftex/Host.h 88.09% <100.00%> (+5.16%) ⬆️

... and 96 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sophie-Xie Sophie-Xie merged commit a6c163c into vesoft-inc:master Sep 19, 2023
3 of 4 checks passed
@nevermore3 nevermore3 deleted the fix_filter_bug branch September 20, 2023 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants