Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit join #5664

Merged
merged 10 commits into from
Aug 7, 2023
Merged

Add explicit join #5664

merged 10 commits into from
Aug 7, 2023

Conversation

nevermore3
Copy link
Contributor

@nevermore3 nevermore3 commented Aug 2, 2023

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

1、 add find single shortest path
2、add explicit join,only inner join is supported now
3、add Keyword
INNER, LEFT, RIGHT , OUTER, SEMI, ANTI, JOIN

Incompatibilities:
 JOIN, OUTER, SEMI, ANTI, INNER changed from non-keywords to keywords

If  use the above keywords as column names or attribute names, you need to add quotation marks when using them.

For example:
(root@nebula) [nba]> YIELD 123 AS join
[ERROR (-1004)]: SyntaxError: syntax error near `join'

Mon, 07 Aug 2023 11:15:27 CST

(root@nebula) [nba]> YIELD 123 AS `join`
+------+
| join |
+------+
| 123  |
+------+
Got 1 rows (time spent 2571/3094 us)

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@nevermore3 nevermore3 force-pushed the add_explicit_join branch 2 times, most recently from ac99ae5 to 48fa17e Compare August 2, 2023 09:05
@nevermore3 nevermore3 added the ready-for-testing PR: ready for the CI test label Aug 2, 2023
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@e320ec5). Click here to learn what that means.
Patch coverage: 66.08% of modified lines in pull request are covered.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #5664   +/-   ##
=========================================
  Coverage          ?   78.24%           
=========================================
  Files             ?     1133           
  Lines             ?    85630           
  Branches          ?        0           
=========================================
  Hits              ?    67003           
  Misses            ?    18627           
  Partials          ?        0           
Files Changed Coverage Δ
src/graph/planner/plan/Query.cpp 68.35% <0.00%> (ø)
src/parser/Clauses.cpp 74.15% <0.00%> (ø)
src/parser/TraverseSentences.cpp 92.15% <33.33%> (ø)
src/parser/Clauses.h 95.71% <86.66%> (ø)
src/graph/validator/YieldValidator.cpp 97.35% <95.00%> (ø)
src/parser/TraverseSentences.h 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nevermore3 nevermore3 requested a review from yixinglu August 4, 2023 10:05
@nevermore3 nevermore3 added ready for review incompatible PR: incompatible with the recently released version labels Aug 4, 2023
yixinglu
yixinglu previously approved these changes Aug 4, 2023
jievince
jievince previously approved these changes Aug 4, 2023
@Sophie-Xie
Copy link
Contributor

which are incompatible?

@nevermore3
Copy link
Contributor Author

which are incompatible?

add some keywords

@dutor dutor merged commit 1f88207 into vesoft-inc:master Aug 7, 2023
@nevermore3 nevermore3 deleted the add_explicit_join branch December 25, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
incompatible PR: incompatible with the recently released version ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants