Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PushLimitDownFulltextIndexScanRule #5601

Merged
merged 3 commits into from
Jun 16, 2023
Merged

Fix PushLimitDownFulltextIndexScanRule #5601

merged 3 commits into from
Jun 16, 2023

Conversation

yixinglu
Copy link
Contributor

@yixinglu yixinglu commented Jun 16, 2023 •
edited
Loading

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

the PushLimitDownFulltextIndexScanRule does not work well since the rule pattern has changed and this issue was introduced in #5597

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.）
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@yixinglu yixinglu added the ready-for-testing PR: ready for the CI test label Jun 16, 2023
@yixinglu yixinglu marked this pull request as ready for review June 16, 2023 06:29
@Sophie-Xie Sophie-Xie merged commit f792c71 into vesoft-inc:master Jun 16, 2023
@yixinglu yixinglu deleted the fix-opt-rule branch June 16, 2023 08:24
yixinglu added a commit to yixinglu/nebula that referenced this pull request Sep 14, 2023
@Sophie-Xie @yixinglu
cherry pick from nebula: Fix PushLimitDownFulltextIndexScanRule (veso…
cbf879e 
…ft-inc#5601) (vesoft-inc#2846)

Fix PushLimitDownFulltextIndexScanRule  (vesoft-inc#5601)

* Fix push limit down ft index scan rule

* Fix limit offset bug in OptRule

* Add plan tests

Co-authored-by: Yee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jievince jievince jievince approved these changes

@nevermore3 nevermore3 nevermore3 approved these changes

@cangfengzhs cangfengzhs Awaiting requested review from cangfengzhs

Assignees
No one assigned
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yixinglu @nevermore3 @jievince @Sophie-Xie