Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix cluster id is not backuped" #5590

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Revert "fix cluster id is not backuped" #5590

merged 1 commit into from
Jun 13, 2023

Conversation

Aiee
Copy link
Contributor

@Aiee Aiee commented Jun 13, 2023

Reverts #5573

@Aiee Aiee added ready-for-testing PR: ready for the CI test ready for review labels Jun 13, 2023
@Aiee Aiee requested review from xtcyclist and critical27 June 13, 2023 03:04
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: +77.69 🎉

Comparison is base (8a49260) 0.00% compared to head (eb99ded) 77.69%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5590       +/-   ##
===========================================
+ Coverage        0   77.69%   +77.69%     
===========================================
  Files           0     1130     +1130     
  Lines           0    85310    +85310     
===========================================
+ Hits            0    66281    +66281     
- Misses          0    19029    +19029     
Impacted Files Coverage Δ
src/common/utils/MetaKeyUtils.cpp 84.80% <ø> (ø)

... and 1129 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Sophie-Xie Sophie-Xie merged commit 57a29e1 into master Jun 13, 2023
@Sophie-Xie Sophie-Xie deleted the revert-5573-fix branch June 13, 2023 05:59
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Sep 14, 2023
…oft-inc#5590) (vesoft-inc#2836)

Revert "fix cluster id is not backuped" (vesoft-inc#5590)

Revert "fix cluster id is not backuped (vesoft-inc#5573)"

This reverts commit e4f91de.

Co-authored-by: Yichen Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants