Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix simple case #5551

Merged
merged 3 commits into from
May 15, 2023
Merged

Fix simple case #5551

merged 3 commits into from
May 15, 2023

Conversation

nevermore3
Copy link
Contributor

@nevermore3 nevermore3 commented May 15, 2023 •
edited
Loading

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.）
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@nevermore3 nevermore3 added ready-for-testing PR: ready for the CI test ready for review labels May 15, 2023
@nevermore3 nevermore3 requested review from yixinglu and jievince May 15, 2023 07:41
yixinglu
yixinglu previously approved these changes May 15, 2023
View reviewed changes
@Sophie-Xie Sophie-Xie added ready-for-testing PR: ready for the CI test and removed ready-for-testing PR: ready for the CI test labels May 15, 2023
@Sophie-Xie Sophie-Xie added ready-for-testing PR: ready for the CI test cherry-pick-v3.5 and removed ready-for-testing PR: ready for the CI test labels May 15, 2023
@yixinglu yixinglu merged commit c2c8447 into vesoft-inc:master May 15, 2023
Sophie-Xie pushed a commit that referenced this pull request May 15, 2023
@nevermore3 @Sophie-Xie
Fix simple case #5551
d1f83d8
@nevermore3 nevermore3 deleted the fix_simple_case branch May 15, 2023 09:24
Sophie-Xie added a commit that referenced this pull request May 15, 2023
@Sophie-Xie @nevermore3
Cherry pick 3.5 (0513-0515) (#5552)
d1e2118 
* change batch size (#5550)

* change batch size

* add flag to config

* Fix simple case #5551

* address conflict

---------

Co-authored-by: jimingquan <[email protected]>
@wey-gu wey-gu mentioned this pull request May 20, 2023
Closed
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Sep 14, 2023
@Sophie-Xie @nevermore3
Cherry pick from nebula: go performance (vesoft-inc#2769)
63c7e26 
* change batch size (vesoft-inc#5550)

* change batch size

* add flag to config

* Fix simple case (vesoft-inc#5551)

* m2n simple case

* add test case

---------

Co-authored-by: Sophie <[email protected]>

---------

Co-authored-by: jimingquan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jievince jievince jievince approved these changes

@yixinglu yixinglu yixinglu approved these changes

Assignees
No one assigned
Labels
already-picked-3.5 cherry-pick-v3.5 ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nevermore3 @yixinglu @jievince @Sophie-Xie