Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent the heartbeat time from going back and causing leader lease invalid #5534

Merged
merged 5 commits into from
May 12, 2023

Conversation

tangyuanzhang
Copy link
Contributor

@tangyuanzhang tangyuanzhang commented May 4, 2023

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

#5265

Description:

When the thread pool is blocked, step2 may also cause the heartbeat to fall back

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@tangyuanzhang tangyuanzhang marked this pull request as ready for review May 9, 2023 10:16
@tangyuanzhang tangyuanzhang requested a review from critical27 as a code owner May 9, 2023 10:16
Copy link
Contributor

@wenhaocs wenhaocs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very impressive finding following the last finding of rocksdb writing stalling causing large lastMsgAcceptedCostMs_! Thanks for the contribution.

@Sophie-Xie Sophie-Xie added the ready-for-testing PR: ready for the CI test label May 12, 2023
@Sophie-Xie Sophie-Xie merged commit 129ccf5 into vesoft-inc:master May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants