-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize-all-path-go #5528
Merged
Merged
optimize-all-path-go #5528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yixinglu
reviewed
Apr 26, 2023
nevermore3
force-pushed
the
fix_all_path
branch
from
April 27, 2023 05:53
cc6f796
to
5d77e30
Compare
nevermore3
force-pushed
the
fix_all_path
branch
from
April 27, 2023 05:53
5d77e30
to
cd46df5
Compare
yixinglu
reviewed
Apr 27, 2023
// add src; | ||
row.values.emplace_back(list.back()); | ||
list.pop_back(); | ||
std::reverse(list.begin(), list.end()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why need to reverse the list?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when recursively parsing vertex and edge through NPath, the order is reversed compared to the topology of the path
nevermore3
force-pushed
the
fix_all_path
branch
6 times, most recently
from
April 27, 2023 09:19
840a417
to
b15aeb0
Compare
nevermore3
force-pushed
the
fix_all_path
branch
from
April 27, 2023 09:42
b15aeb0
to
b867b55
Compare
nevermore3
force-pushed
the
fix_all_path
branch
from
April 27, 2023 09:46
b867b55
to
b49be07
Compare
yixinglu
approved these changes
Apr 27, 2023
xtcyclist
approved these changes
Apr 27, 2023
Sophie-Xie
added a commit
that referenced
this pull request
Apr 27, 2023
* fixed yapf version (#5513) * Update requirements.txt fixed yapf version to the last version supporting tomli 1.x * Update requirements.txt fix typo * update unsupported action syntax (#5527) update unsupported syntax * optimize-all-path-go (#5528) --------- Co-authored-by: George <[email protected]> Co-authored-by: jimingquan <[email protected]>
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this pull request
Sep 14, 2023
Co-authored-by: jimingquan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
close https://github.com/vesoft-inc/nebula-ent/issues/2725
Description:
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: