Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If user does not exist desc user xxx will be raise "User not existed!" #5345

Merged
merged 1 commit into from
Feb 20, 2023

Conversation

Milittle
Copy link
Contributor

@Milittle Milittle commented Feb 15, 2023

If user does not exist desc user xxx will be raise "User not existed!"

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Close #5141

Description:

If use does not exist desc user xxx will be raise "User not existed!"

How do you solve it?

add account exist verify in meta service

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:
manunal test:

(root@nebula) [(none)]> desc user u6
[ERROR (-1005)]: User not existed!

Wed, 15 Feb 2023 22:43:06 CST
  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@CLAassistant
Copy link

CLAassistant commented Feb 15, 2023

CLA assistant check
All committers have signed the CLA.

@Milittle
Copy link
Contributor Author

Milittle commented Feb 15, 2023

if have any problem, leave message here, thanks.

May i need change my git account. wait me fix this.

@Sophie-Xie
Copy link
Contributor

if have any problem, leave message here, thanks.

May i need change my git account. wait me fix this.

Thanks for contribution! Pls fix the CI when your account is OK. :)

@Milittle Milittle force-pushed the master branch 3 times, most recently from b76e0fe to 35d0c56 Compare February 18, 2023 12:10
@Milittle
Copy link
Contributor Author

if have any problem, leave message here, thanks.
May i need change my git account. wait me fix this.

Thanks for contribution! Pls fix the CI when your account is OK. :)

Done

@Milittle Milittle changed the title If use does not exist desc user xxx will be raise "User not existed!" If user does not exist desc user xxx will be raise "User not existed!" Feb 18, 2023
Copy link
Contributor

@yixinglu yixinglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job!

@yixinglu yixinglu merged commit 9845dd7 into vesoft-inc:master Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Desc not existed user should report error
5 participants