Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the crash caused by failed downcast of iter #5291

Merged
merged 1 commit into from
Feb 1, 2023

Conversation

xtcyclist
Copy link
Contributor

@xtcyclist xtcyclist commented Jan 31, 2023

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Close https://github.com/vesoft-inc/nebula-ent/issues/2336
Close #5292

Description:

The cast of iter to GetNeighborsIter using static_cast may fail and leave a non-accessible GetNeighborsIter*, which would later crash the graphd on seg fault.

How do you solve it?

Tried using dynamic_cast. On the advice by @yixinglu, changed to protect the static_cast by checking the kind of iter.

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@xtcyclist xtcyclist added the ready-for-testing PR: ready for the CI test label Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

graph crash: upgrade from ent3.2.2 to ent3.4 and run tck
5 participants