Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log enhance #5261

Merged
merged 4 commits into from
Jan 31, 2023
Merged

log enhance #5261

merged 4 commits into from
Jan 31, 2023

Conversation

SuperYoko
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

Some log is confusing.

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@SuperYoko SuperYoko marked this pull request as ready for review January 18, 2023 04:59
@SuperYoko SuperYoko added the ready-for-testing PR: ready for the CI test label Jan 18, 2023
@codecov-commenter
Copy link

Codecov Report

Base: 77.60% // Head: 78.67% // Increases project coverage by +1.06% 🎉

Coverage data is based on head (44b76cd) compared to base (f3b1ed6).
Patch coverage: 54.54% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5261      +/-   ##
==========================================
+ Coverage   77.60%   78.67%   +1.06%     
==========================================
  Files        1110     1110              
  Lines       82995    83006      +11     
==========================================
+ Hits        64410    65304     +894     
+ Misses      18585    17702     -883     
Impacted Files Coverage Δ
src/storage/admin/RebuildIndexTask.cpp 74.09% <33.33%> (-0.91%) ⬇️
src/meta/processors/job/JobManager.cpp 77.98% <50.00%> (-0.30%) ⬇️
src/storage/admin/AdminTaskManager.cpp 82.25% <100.00%> (+1.20%) ⬆️
src/common/memory/NewDelete.cpp 56.25% <0.00%> (-6.25%) ⬇️
src/common/thread/GenericWorker.h 80.76% <0.00%> (-3.85%) ⬇️
src/storage/transaction/TransactionManager.cpp 39.45% <0.00%> (-2.71%) ⬇️
src/common/memory/Memory.h 82.92% <0.00%> (-2.44%) ⬇️
src/common/expression/UnaryExpression.cpp 83.69% <0.00%> (-1.86%) ⬇️
src/graph/executor/query/ProjectExecutor.cpp 59.45% <0.00%> (-1.66%) ⬇️
src/common/process/ProcessUtils.cpp 84.70% <0.00%> (-1.18%) ⬇️
... and 69 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@critical27 critical27 merged commit db7606b into vesoft-inc:master Jan 31, 2023
@SuperYoko SuperYoko deleted the enhance_log branch March 28, 2023 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants