More lookup TCK tests #5218
Merged
More lookup TCK tests #5218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nevermore3
approved these changes
Jan 30, 2023
czpmango
reviewed
Jan 30, 2023
| # (TODO) Unsupported cases due to the lack of float precision | ||
| When executing query: | ||
| """ | ||
| LOOKUP ON weight WHERE weight.WEIGHT > 70.5 YIELD id(vertex) as name; |
There was a problem hiding this comment.
YIELD weight.WEIGHT for more intuitive validation. Any issue related to float precision here?
czpmango
reviewed
Jan 30, 2023
| @@ -133,3 +133,55 @@ Feature: Push Limit down IndexScan Rule | |||
| | 7 | Limit | 8 | | | |||
| | 8 | EdgeIndexPrefixScan | 9 | {"limit": "3"} | | |||
| | 9 | Start | | | | |||
|
|
|||
| Scenario: some variables in where clause of lookup statement | |||
There was a problem hiding this comment.
Add some test cases related to cypher variable:
UNWIND ["A", "B"] AS name | LOOKUP ON player WHERE player.name starts with $-.name YIELD id(vertex) as id;
UNWIND ["A", "B"] AS name | LOOKUP ON player YIELD id(vertex) as id;
czpmango
approved these changes
Jan 30, 2023
Sophie-Xie
added a commit
that referenced
this pull request
Feb 2, 2023
* More lookup tests on ngdata * Test edge property of double and geography types * Restore geography test for lookup * comment back tests * More lookup test cases * restore ngdata tests * drop the used space * Fix failed * refine step * some variables in where clause of lookup statement * some variabes in yield clause of lookup statement * More yield variable test --------- Co-authored-by: Sophie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
vesoft-inc/nebula-ent#1754
Description:
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: