Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor bug for adminTaskManager #5195

Merged
merged 4 commits into from
Jan 5, 2023
Merged

minor bug for adminTaskManager #5195

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c2ff9a7
minor bug for adminTaskManager
liwenhui-soul Jan 4, 2023
fe276f6
Merge branch 'master' into job
liwenhui-soul Jan 5, 2023
d0962a2
Merge branch 'master' into job
Sophie-Xie Jan 5, 2023
af3af42
Merge branch 'master' into job
Sophie-Xie Jan 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions src/storage/admin/AdminTaskManager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ void AdminTaskManager::handleUnreportedTasks() {
jId,
tId,
fut.value().status().toString());
if (fut.value().status() == Status::Error("Space not existed!")) {
if (fut.value().status() == Status::SpaceNotFound("Space not existed!")) {
// space has been dropped, remove the task status.
keys.emplace_back(key.data(), key.size());
} else {
Expand All @@ -135,13 +135,10 @@ void AdminTaskManager::handleUnreportedTasks() {
jId,
tId,
apache::thrift::util::enumNameSafe(rc));
if (rc == nebula::cpp2::ErrorCode::E_LEADER_CHANGED ||
rc == nebula::cpp2::ErrorCode::E_STORE_FAILURE) {
ifAnyUnreported_ = true;
continue;
} else {
if (rc == nebula::cpp2::ErrorCode::SUCCEEDED) {
keys.emplace_back(key.data(), key.size());
break;
} else {
ifAnyUnreported_ = true;
}
}
env_->adminStore_->multiRemove(keys);
Expand Down