Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clang compilation #5172

Merged
merged 8 commits into from
Dec 30, 2022
Merged

Fix clang compilation #5172

merged 8 commits into from
Dec 30, 2022

Conversation

Aiee
Copy link
Contributor

@Aiee Aiee commented Dec 30, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@Aiee Aiee added ready-for-testing PR: ready for the CI test type/bug Type: something is unexpected ready for review labels Dec 30, 2022
@Aiee Aiee requested review from codesigner and jievince December 30, 2022 09:08
jievince
jievince previously approved these changes Dec 30, 2022
codesigner
codesigner previously approved these changes Dec 30, 2022
czpmango
czpmango previously approved these changes Dec 30, 2022
@Aiee Aiee dismissed stale reviews from czpmango, codesigner, and jievince via 54bd80d December 30, 2022 09:21
czpmango
czpmango previously approved these changes Dec 30, 2022
Shylock-Hg
Shylock-Hg previously approved these changes Dec 30, 2022
@codesigner codesigner dismissed stale reviews from Shylock-Hg and czpmango via 4128f44 December 30, 2022 12:46
@Sophie-Xie Sophie-Xie merged commit 7047fb7 into vesoft-inc:master Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review ready-for-testing PR: ready for the CI test type/bug Type: something is unexpected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants