Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error msg trancated #5150

Merged
merged 3 commits into from
Dec 29, 2022
Merged

Conversation

jievince
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

The format function will truncate the error message that Status::Error used if it is longer than 256 bytes.

std::string Status::format(const char *fmt, va_list args) {
  char result[256];
  vsnprintf(result, sizeof(result), fmt, args);
  return result;
}

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@jievince jievince added the ready-for-testing PR: ready for the CI test label Dec 29, 2022
@jievince jievince force-pushed the fix-error-trancated branch from 05998fd to 849ed6f Compare December 29, 2022 04:02
Sophie-Xie
Sophie-Xie previously approved these changes Dec 29, 2022
@Sophie-Xie Sophie-Xie merged commit 9c81cdd into vesoft-inc:master Dec 29, 2022
@jievince jievince deleted the fix-error-trancated branch December 29, 2022 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants