Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a crash bug. Deduce props in yield. #5121

Merged
merged 1 commit into from
Dec 27, 2022

Conversation

xtcyclist
Copy link
Contributor

@xtcyclist xtcyclist commented Dec 27, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Close #5111

Description:

Yield after the pipe operator fails to get its input variable correctly, causing the aggregate executor to use a DefaultIterator from an empty dataset, many unimplemented methods of which contain LOG(FATAL) that crashes the service.

How do you solve it?

Deduce properties for aggregate expressions, allowing it to get its input variable generated before the pipe operator correctly.

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • TCK

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@Shylock-Hg
Copy link
Contributor

Add test?

@xtcyclist xtcyclist added the priority/hi-pri Priority: high label Dec 27, 2022
@xtcyclist
Copy link
Contributor Author

Add test?

added

@Sophie-Xie Sophie-Xie merged commit c1298dd into vesoft-inc:master Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/hi-pri Priority: high ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

graphd crash when executing avg +1
4 participants