parameter tck #5079
Merged
parameter tck #5079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caton-hpg
force-pushed
the
parameter-tck
branch
from
e57ff95 to
236c1d0
Compare
jievince
previously approved these changes
Dec 23, 2022
czpmango
reviewed
Dec 23, 2022
| @@ -209,3 +266,11 @@ Feature: Parameter | |||
| """ | |||
| Then a SyntaxError should be raised at runtime: Direct output of variable is prohibited near `$var' | |||
| Then clear the used parameters | |||
|
|
|||
There was a problem hiding this comment.
Please add some test scenarios where parameter expressions and variable expressions are mixed.
There was a problem hiding this comment.
$var=go from "Tim Duncan" over like yield like._dst as id
| yield $-.id+$p1+count(distinct abs($p1)+$-.id)
czpmango
reviewed
Dec 23, 2022
| @@ -7,16 +7,48 @@ Feature: Parameter | |||
| Given a graph with space named "nba" | |||
| Given parameters: {"p1":1,"p2":true,"p3":"Tim Duncan","p4":3.3,"p5":[1,true,3],"p6":{"a":3,"b":false,"c":"Tim Duncan"},"p7":{"a":{"b":{"c":"Tim Duncan","d":[1,2,3,true,"Tim Duncan"]}}},"p8":"Manu Ginobili", "p9":["Tim Duncan","Tony Parker"]} | |||
|
|
|||
| Scenario: return parameters | |||
| Scenario: [param-test-001] without define param | |||
There was a problem hiding this comment.
Add some test scenarios where parameter expressions and aggregate expressions are mixed.
czpmango
reviewed
Dec 23, 2022
| Scenario: [param-test-002] support null | ||
| When executing query: | ||
| """ | ||
| RETURN $p1 is not null AS v |
There was a problem hiding this comment.
Need to add some more complex expression scenarios, such as expression nesting, type checking, runtime error, etc.
caton-hpg
force-pushed
the
parameter-tck
branch
2 times, most recently
from
711b6f3 to
914d027
Compare
czpmango
reviewed
Dec 27, 2022
czpmango
previously approved these changes
Dec 27, 2022
caton-hpg
force-pushed
the
parameter-tck
branch
from
7f94423 to
6077ac4
Compare
czpmango
approved these changes
Dec 28, 2022
Sophie-Xie
approved these changes
Dec 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
update tck of parameter
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes: