-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace LOG(FATAL) with LOG(DFATAL) #5078
Conversation
Codecov ReportBase: 77.34% // Head: 77.18% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5078 +/- ##
==========================================
- Coverage 77.34% 77.18% -0.17%
==========================================
Files 1105 1106 +1
Lines 82146 82348 +202
==========================================
+ Hits 63539 63561 +22
- Misses 18607 18787 +180
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you can revert the changes in dir src/kvstore
. They rarely fail, and if it really happens, we'd better crash there.
ok |
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
fix #5068
Description:
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: