Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace LOG(FATAL) with LOG(DFATAL) #5078

Merged
merged 3 commits into from
Dec 27, 2022
Merged

Conversation

veezhang
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

fix #5068

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@veezhang veezhang added the wip Solution: work in progress label Dec 19, 2022
@veezhang veezhang requested a review from critical27 as a code owner December 20, 2022 12:04
@veezhang veezhang added ready-for-testing PR: ready for the CI test and removed wip Solution: work in progress labels Dec 21, 2022
@Sophie-Xie Sophie-Xie requested a review from xtcyclist December 21, 2022 03:57
@codecov-commenter
Copy link

Codecov Report

Base: 77.34% // Head: 77.18% // Decreases project coverage by -0.16% ⚠️

Coverage data is based on head (ddbb5a9) compared to base (70d0bb2).
Patch coverage: 3.92% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5078      +/-   ##
==========================================
- Coverage   77.34%   77.18%   -0.17%     
==========================================
  Files        1105     1106       +1     
  Lines       82146    82348     +202     
==========================================
+ Hits        63539    63561      +22     
- Misses      18607    18787     +180     
Impacted Files Coverage Δ
src/clients/meta/MetaClient.cpp 76.12% <0.00%> (-0.23%) ⬇️
src/codec/RowReaderV1.cpp 70.71% <0.00%> (-0.26%) ⬇️
src/codec/RowReaderV2.cpp 92.96% <0.00%> (-1.48%) ⬇️
src/codec/RowWriterV2.cpp 84.26% <0.00%> (-0.65%) ⬇️
src/common/base/Arena.cpp 90.47% <0.00%> (-4.53%) ⬇️
src/common/base/Status.cpp 60.00% <0.00%> (-3.30%) ⬇️
src/common/expression/ArithmeticExpression.cpp 88.00% <0.00%> (-3.67%) ⬇️
src/common/expression/Expression.cpp 52.47% <0.00%> (-0.47%) ⬇️
src/common/expression/LabelAttributeExpression.h 70.58% <0.00%> (-6.84%) ⬇️
src/common/expression/LogicalExpression.cpp 91.89% <0.00%> (-1.69%) ⬇️
... and 136 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@veezhang veezhang requested a review from xtcyclist December 22, 2022 10:24
@xtcyclist xtcyclist changed the title fix: FATAL Replace LOG(FATAL) with LOG(DFATAL) Dec 23, 2022
@Sophie-Xie Sophie-Xie added the priority/hi-pri Priority: high label Dec 26, 2022
xtcyclist
xtcyclist previously approved these changes Dec 26, 2022
Copy link
Contributor

@critical27 critical27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you can revert the changes in dir src/kvstore. They rarely fail, and if it really happens, we'd better crash there.

@veezhang
Copy link
Contributor Author

Maybe you can revert the changes in dir src/kvstore. They rarely fail, and if it really happens, we'd better crash there.

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/hi-pri Priority: high ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce the usages of LOG(FATAL) or other self-descruction measures as many as possible.
5 participants