Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checking update filter expression. #5076

Merged
merged 3 commits into from
Dec 27, 2022

Conversation

Shylock-Hg
Copy link
Contributor

@Shylock-Hg Shylock-Hg commented Dec 19, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Close #5046

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@Shylock-Hg Shylock-Hg added type/bug Type: something is unexpected ready-for-testing PR: ready for the CI test labels Dec 19, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 77.24% // Head: 77.47% // Increases project coverage by +0.23% 🎉

Coverage data is based on head (3ed2d2c) compared to base (cc0ce34).
Patch coverage: 83.65% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5076      +/-   ##
==========================================
+ Coverage   77.24%   77.47%   +0.23%     
==========================================
  Files        1105     1103       -2     
  Lines       82054    81936     -118     
==========================================
+ Hits        63383    63481      +98     
+ Misses      18671    18455     -216     
Impacted Files Coverage Δ
src/clients/meta/MetaClient.cpp 76.26% <0.00%> (-0.28%) ⬇️
src/clients/storage/StorageClientBase-inl.h 76.71% <0.00%> (ø)
src/graph/executor/StorageAccessExecutor.h 56.81% <0.00%> (-1.33%) ⬇️
src/graph/executor/admin/ShowHostsExecutor.cpp 93.54% <ø> (+0.99%) ⬆️
src/graph/executor/query/ProjectExecutor.cpp 62.85% <ø> (-1.04%) ⬇️
src/graph/optimizer/Optimizer.h 100.00% <ø> (ø)
src/meta/processors/BaseProcessor.h 76.92% <ø> (ø)
src/graph/service/QueryInstance.cpp 80.13% <50.00%> (-0.56%) ⬇️
src/graph/validator/MatchValidator.cpp 89.51% <75.00%> (-0.08%) ⬇️
src/graph/executor/query/TraverseExecutor.cpp 84.90% <82.06%> (+16.88%) ⬆️
... and 41 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@codesigner codesigner merged commit 45f5bfd into vesoft-inc:master Dec 27, 2022
@Shylock-Hg Shylock-Hg deleted the fix/check-update-filter-2 branch December 27, 2022 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test type/bug Type: something is unexpected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

date typed prop equal date() error in UPDATE WHEN expression
5 participants