-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor enhancement about error message #5064
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR!
Codecov ReportBase: 77.24% // Head: 77.30% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5064 +/- ##
==========================================
+ Coverage 77.24% 77.30% +0.05%
==========================================
Files 1105 1105
Lines 82129 82132 +3
==========================================
+ Hits 63442 63491 +49
+ Misses 18687 18641 -46
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good job
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Close #4947, #4948, https://github.com/vesoft-inc/nebula-ent/issues/1890, https://github.com/vesoft-inc/nebula-ent/issues/1749
Description:
Mainly to improve some error code and error message, skip db_dump tool when packaging.
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: