Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor enhancement about error message #5064

Merged
merged 3 commits into from
Dec 16, 2022
Merged

Conversation

critical27
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Close #4947, #4948, https://github.com/vesoft-inc/nebula-ent/issues/1890, https://github.com/vesoft-inc/nebula-ent/issues/1749

Description:

Mainly to improve some error code and error message, skip db_dump tool when packaging.

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@critical27 critical27 added ready-for-testing PR: ready for the CI test ready for review labels Dec 16, 2022
@critical27 critical27 requested review from SuperYoko, pengweisong and a team December 16, 2022 02:59
@critical27 critical27 requested a review from a team as a code owner December 16, 2022 02:59
Copy link
Contributor

@xtcyclist xtcyclist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR!

@Sophie-Xie Sophie-Xie added ready-for-testing PR: ready for the CI test and removed ready-for-testing PR: ready for the CI test labels Dec 16, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 77.24% // Head: 77.30% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (a1999f7) compared to base (c3866b3).
Patch coverage: 53.84% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5064      +/-   ##
==========================================
+ Coverage   77.24%   77.30%   +0.05%     
==========================================
  Files        1105     1105              
  Lines       82129    82132       +3     
==========================================
+ Hits        63442    63491      +49     
+ Misses      18687    18641      -46     
Impacted Files Coverage Δ
src/clients/meta/MetaClient.cpp 76.07% <0.00%> (-0.12%) ⬇️
src/clients/storage/StorageClientBase-inl.h 76.71% <0.00%> (ø)
src/graph/executor/StorageAccessExecutor.h 54.54% <0.00%> (-3.60%) ⬇️
src/meta/processors/BaseProcessor.h 76.92% <ø> (ø)
src/meta/processors/BaseProcessor-inl.h 86.85% <100.00%> (ø)
...meta/processors/index/CreateEdgeIndexProcessor.cpp 71.95% <100.00%> (ø)
.../meta/processors/index/CreateTagIndexProcessor.cpp 71.77% <100.00%> (ø)
src/meta/processors/schema/CreateTagProcessor.cpp 77.77% <100.00%> (ø)
src/storage/mutate/AddVerticesProcessor.cpp 86.07% <0.00%> (-2.11%) ⬇️
... and 33 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@critical27 critical27 merged commit 5b5a49b into vesoft-inc:master Dec 16, 2022
@critical27 critical27 deleted the fix branch December 16, 2022 06:54
Copy link
Contributor

@pengweisong pengweisong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor the error message: Storage Error E_RPC_FAILURE, to reflect a clear error that the use could act upon
7 participants