Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about test data. #5057

Merged
merged 2 commits into from
Dec 16, 2022

Conversation

Shylock-Hg
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@Shylock-Hg Shylock-Hg added the ready-for-testing PR: ready for the CI test label Dec 15, 2022
Copy link
Contributor

@yixinglu yixinglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only so simple notes? Is there anything else?

@Shylock-Hg
Copy link
Contributor Author

Only so simple notes? Is there anything else?

No

@Shylock-Hg Shylock-Hg requested a review from yixinglu December 16, 2022 02:26
@codecov-commenter
Copy link

Codecov Report

Base: 77.24% // Head: 77.31% // Increases project coverage by +0.06% 🎉

Coverage data is based on head (7cce843) compared to base (c3866b3).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5057      +/-   ##
==========================================
+ Coverage   77.24%   77.31%   +0.06%     
==========================================
  Files        1105     1105              
  Lines       82129    82135       +6     
==========================================
+ Hits        63442    63502      +60     
+ Misses      18687    18633      -54     
Impacted Files Coverage Δ
src/storage/mutate/AddEdgesProcessor.cpp 78.62% <0.00%> (-2.22%) ⬇️
src/parser/GraphScanner.h 92.63% <0.00%> (-2.00%) ⬇️
src/kvstore/raftex/Host.cpp 71.70% <0.00%> (-1.93%) ⬇️
src/codec/RowReaderWrapper.h 95.08% <0.00%> (-1.59%) ⬇️
src/common/process/ProcessUtils.cpp 84.70% <0.00%> (-1.18%) ⬇️
src/kvstore/listener/Listener.cpp 82.97% <0.00%> (-1.07%) ⬇️
src/kvstore/Part.cpp 53.29% <0.00%> (-0.70%) ⬇️
src/kvstore/raftex/RaftPart.cpp 69.98% <0.00%> (-0.50%) ⬇️
src/storage/query/QueryBaseProcessor-inl.h 79.65% <0.00%> (-0.46%) ⬇️
src/common/datatypes/ValueOps-inl.h 60.71% <0.00%> (-0.38%) ⬇️
... and 25 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Sophie-Xie Sophie-Xie merged commit 3212939 into vesoft-inc:master Dec 16, 2022
@Shylock-Hg Shylock-Hg deleted the enhancement/test-data-note branch December 16, 2022 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants