-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix expressions that shall be rewritten to LabelTagProperty #5054
Conversation
7643451
to
acbd7a6
Compare
5808198
to
0a07d8c
Compare
64fa6e7
to
964e67a
Compare
5c6de3b
to
4b3841c
Compare
616b7f1
to
18510c2
Compare
7677635
to
70c5624
Compare
…ated cases such as ListComprehensionExpression, reduce, etc.
70c5624
to
06dd8ca
Compare
Codecov ReportBase: 77.34% // Head: 77.31% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5054 +/- ##
==========================================
- Coverage 77.34% 77.31% -0.03%
==========================================
Files 1105 1105
Lines 82127 82148 +21
==========================================
- Hits 63518 63511 -7
- Misses 18609 18637 +28
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Close #5051
Description:
LabelTagProperty expressions in unwind are treated as AttributeExpressions, causing property-not-found errors.
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: