Pass aliases from unwind to project. #5045
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Fix #5022
Description:
Consider a clause segment like "unwind a as b with *". The project operator generated to implement "with *" shall carry on all aliases from its previous "unwind" clause, consisting of the aliases that the unwind passes on as well as the alises it generated (e.g., the b in this example).
In the current implementation, only the
unwindCtx->alias
(e.g., the b in this example) is added into the project. With only this alias passed, there would be missing columns in the project's output variable, which in turn would prevent the argument operator, if any, to find its needed columns for its input variable.Argument will NULL input variable crashses the graphd.
Detailed analysis of the crash bug has been posted in the above issue.
How do you solve it?
Added aliasesAvailable and aliasesGenerated into the project as well, for the project after wind.
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: