Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support storaged-listener script startup #5035

Merged
merged 4 commits into from
Dec 13, 2022

Conversation

panda-sheep
Copy link
Contributor

@panda-sheep panda-sheep commented Dec 9, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

Sync pr from enterprise version pr https://github.com/vesoft-inc/nebula-ent/pull/1275
close #5034
Use as follows

./scripts/nebula-storaged-listener.service start
./scripts/nebula-storaged-listener.service status
./scripts/nebula-storaged-listener.service stop

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@panda-sheep panda-sheep requested a review from dutor December 12, 2022 01:24
@codecov-commenter
Copy link

Codecov Report

Base: 77.24% // Head: 77.26% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (0e3ef58) compared to base (cc0ce34).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5035      +/-   ##
==========================================
+ Coverage   77.24%   77.26%   +0.01%     
==========================================
  Files        1105     1105              
  Lines       82054    82054              
==========================================
+ Hits        63383    63398      +15     
+ Misses      18671    18656      -15     
Impacted Files Coverage Δ
src/common/thread/GenericWorker.h 80.76% <0.00%> (-3.85%) ⬇️
src/kvstore/raftex/Host.cpp 71.70% <0.00%> (-2.58%) ⬇️
src/meta/processors/parts/ListHostsProcessor.cpp 69.52% <0.00%> (-2.15%) ⬇️
src/storage/mutate/AddVerticesProcessor.cpp 86.07% <0.00%> (-2.11%) ⬇️
src/graph/executor/query/ProjectExecutor.cpp 62.16% <0.00%> (-1.73%) ⬇️
src/codec/RowReaderWrapper.h 95.08% <0.00%> (-1.64%) ⬇️
src/common/process/ProcessUtils.cpp 84.70% <0.00%> (-1.18%) ⬇️
src/graph/optimizer/Optimizer.cpp 91.15% <0.00%> (-0.89%) ⬇️
src/kvstore/Part.cpp 54.91% <0.00%> (-0.86%) ⬇️
src/kvstore/raftex/RaftPart.cpp 70.79% <0.00%> (-0.82%) ⬇️
... and 28 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@critical27 critical27 merged commit 49fe2bc into vesoft-inc:master Dec 13, 2022
@panda-sheep panda-sheep deleted the add_listener_startup_script branch December 13, 2022 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provides a startup script for the listener
7 participants