Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a tck. #5029

Merged
merged 2 commits into from
Dec 9, 2022
Merged

Fix a tck. #5029

merged 2 commits into from
Dec 9, 2022

Conversation

xtcyclist
Copy link
Contributor

@xtcyclist xtcyclist commented Dec 9, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

Replace insert/delete vertices/edges in a tck with operating on a new empty graph.

This fix has been applied in the ent repo.

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • TCK

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@codecov-commenter
Copy link

Codecov Report

Base: 76.86% // Head: 77.21% // Increases project coverage by +0.34% 🎉

Coverage data is based on head (3c4bb8e) compared to base (8adec8d).
Patch coverage: 74.12% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5029      +/-   ##
==========================================
+ Coverage   76.86%   77.21%   +0.34%     
==========================================
  Files        1105     1105              
  Lines       81432    82057     +625     
==========================================
+ Hits        62594    63358     +764     
+ Misses      18838    18699     -139     
Impacted Files Coverage Δ
src/common/datatypes/Value.h 97.05% <ø> (ø)
src/common/expression/TextSearchExpression.h 77.58% <ø> (+20.68%) ⬆️
src/common/http/HttpClient.h 100.00% <ø> (ø)
src/graph/context/Iterator.h 69.23% <0.00%> (ø)
src/graph/context/Symbols.h 100.00% <ø> (ø)
src/graph/executor/admin/SpaceExecutor.cpp 76.19% <0.00%> (-0.74%) ⬇️
src/graph/executor/maintain/FTIndexExecutor.cpp 0.00% <0.00%> (ø)
src/graph/executor/query/TraverseExecutor.h 100.00% <ø> (ø)
src/graph/optimizer/Optimizer.h 100.00% <ø> (ø)
src/graph/planner/match/ArgumentFinder.cpp 88.88% <ø> (-1.59%) ⬇️
... and 137 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@xtcyclist xtcyclist requested a review from yixinglu December 9, 2022 05:44
@codesigner codesigner merged commit a7b28fd into vesoft-inc:master Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants