Feature/test data #4995
Feature/test data #4995
Conversation
… feature/test-data
Shylock-Hg
requested review from
yixinglu,
czpmango,
dutor,
jievince,
kikimo and
xtcyclist
| | 2 | Start | | | | ||
| | id | name | dependencies | operator info | | ||
| | 8 | Project | 4 | | | ||
| | 4 | AppendVertices | 3 | { "props": "[{\"props\":[\"age\"],\"tagId\": 3}]" } | |
There was a problem hiding this comment.
maybe we should remove the tagId from the tests since it depends on the runtime environment.
There was a problem hiding this comment.
Agree, better display name instead of Id. Could do it in later PR.
| @@ -98,7 +98,7 @@ class Prop(Column): | |||
| def __init__(self, index: int, name: str, ptype: str): | |||
| super().__init__(index) | |||
| self._name = name | |||
| if ptype not in ['string', 'int', 'double']: | |||
| if ptype not in ['string', 'int', 'double', 'bool']: | |||
There was a problem hiding this comment.
So, there is no time props?
There was a problem hiding this comment.
Or any complex props, like List, Map?
There was a problem hiding this comment.
Yes, the generator doesn't support temporal types, you could submit an issue. Nebula doesn't support list/map as property.
There was a problem hiding this comment.
Yes, the generator doesn't support temporal types, you could submit an issue. Nebula doesn't support list/map as property.
This is not what we required previously, this need further refinement in the fufure.
| @@ -98,7 +98,7 @@ class Prop(Column): | |||
| def __init__(self, index: int, name: str, ptype: str): | |||
| super().__init__(index) | |||
| self._name = name | |||
| if ptype not in ['string', 'int', 'double']: | |||
| if ptype not in ['string', 'int', 'double', 'bool']: | |||
There was a problem hiding this comment.
Yes, the generator doesn't support temporal types, you could submit an issue. Nebula doesn't support list/map as property.
This is not what we required previously, this need further refinement in the fufure.
| charset: utf8 | ||
| collate: utf8_bin | ||
| schema: |- | ||
| CREATE TAG Label_0 (Label_0_2_Bool Bool, Label_0_5_Int Int, Label_0_6_Double Double, Label_0_8_Double Double, Label_0_9_Double Double, Label_0_10_Bool Bool, Label_0_0_String String, Label_0_1_Int Int, Label_0_3_Int Int, Label_0_4_Int Int, Label_0_7_Bool Bool); |
There was a problem hiding this comment.
Can we describe the schema like the picture in LDBC spec?
Codecov ReportBase: 76.86% // Head: 77.22% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #4995 +/- ##
==========================================
+ Coverage 76.86% 77.22% +0.36%
==========================================
Files 1105 1105
Lines 81432 82059 +627
==========================================
+ Hits 62594 63374 +780
+ Misses 18838 18685 -153
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
Generated by https://github.com/vesoft-inc/nebula-test/tree/app-fuzzer/functional/GDLancer . If you have some suggestions, submit issue in https://github.com/vesoft-inc/nebula-test
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: