-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix no print to console #4993
fix no print to console #4993
Conversation
Maybe clone an issue here to make all your links accessable. |
Codecov ReportBase: 76.86% // Head: 76.83% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #4993 +/- ##
==========================================
- Coverage 76.86% 76.83% -0.04%
==========================================
Files 1105 1105
Lines 81432 81464 +32
==========================================
- Hits 62594 62589 -5
- Misses 18838 18875 +37
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
okey |
close #4994 |
don't merge plz, the log could not be removed directly. have talked with qa, this issue don't need to fix because it only happen in v3. if the issue is really need to fix, I suggest refactor the mkdir function to make sure it won't affect other place's log. |
Not a big issue, print some unexpected log before setting up glog is reasonable. And this log is a v3 log, we won't use it for any production env. |
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
fix the enterprise version problem(close https://github.com/vesoft-inc/nebula-ent/issues/1813 ), the community version also exists, just submit it in the community version:
1 Before the
FLAGS_log_dir
directory is generated, you can useLOG(ERROR)
to print errors to standard output, but you cannot usevlog
to print log information. The reasons are as follows:Calling
vlog
before creating theFLAGS_log_dir
directory will cause the following error message:This information is not what we want to output.
Calling
LOG(ERROR)
before creating theFLAGS_log_dir
directory will cause an error message similar to the following:Here, because there is no
FLAGS_log_dir
directory, it is reasonable to print the error to the standard err.2
vlog
Information inFileUtils::fileType
is redundant and meaningless, so remove them.How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: